mxm commented on code in PR #728:
URL: 
https://github.com/apache/flink-kubernetes-operator/pull/728#discussion_r1426564377


##########
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/config/AutoScalerOptions.java:
##########
@@ -72,6 +72,15 @@ private static ConfigOptions.OptionBuilder 
autoScalerConfig(String key) {
                     .withDescription(
                             "Stabilization period in which no new scaling will 
be executed");
 
+    public static final ConfigOption<List<String>> FORBID_PERIOD =
+            autoScalerConfig("forbid.periods")
+                    .stringType()
+                    .asList()
+                    .defaultValues()
+                    
.withDeprecatedKeys(deprecatedOperatorConfigKey("forbid.periods"))
+                    .withDescription(
+                            "A (semicolon-separated) list of certain times of 
the day during which autoscaling is forbidden, 
10:00:00-11:00:00;21:30:00-22:30:00 for example");

Review Comment:
   Yes, if the cron-based notation allows time ranges that would be perfect. We 
could just use UTC and document this for now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to