KarmaGYZ commented on code in PR #23635:
URL: https://github.com/apache/flink/pull/23635#discussion_r1413318476
##########
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/DeclarativeSlotPoolService.java:
##########
@@ -110,7 +110,7 @@ public <T> Optional<T> castInto(Class<T> clazz) {
}
@Override
- public final void start(
Review Comment:
There is no need to do this. Just override the onStart.
##########
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/DeclarativeSlotPoolService.java:
##########
@@ -142,7 +142,7 @@ protected void assertHasBeenStarted() {
}
@Override
- public final void close() {
Review Comment:
ditto. Override the onClose
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
