KarmaGYZ commented on code in PR #23635:
URL: https://github.com/apache/flink/pull/23635#discussion_r1427515551
##########
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/DefaultDeclarativeSlotPool.java:
##########
@@ -127,7 +155,28 @@ public void increaseResourceRequirementsBy(ResourceCounter
increment) {
}
totalResourceRequirements = totalResourceRequirements.add(increment);
+ if (slotRequestMaxInterval == null) {
+ declareResourceRequirements();
+ return;
+ }
+
+ Preconditions.checkNotNull(componentMainThreadExecutor);
+ if (slotRequestMaxIntervalTimeoutCheckFuture != null) {
+ slotRequestMaxIntervalTimeoutCheckFuture.cancel(true);
Review Comment:
In current approach, we will minimize the rpc calls. The other approach may
benefit the e2e latency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
