snuyanzin commented on code in PR #23917: URL: https://github.com/apache/flink/pull/23917#discussion_r1428199378
########## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/utils/StreamingWithStateTestBase.scala: ########## @@ -68,8 +69,8 @@ class StreamingWithStateTestBase(state: StateBackendMode) extends StreamingTestB super.before() // set state backend - // subfolder are managed here because the tests could fail during cleanup when concurrently executed (see FLINK-33820) - baseCheckpointPath = TempDirUtils.newFolder(tempFolder) + val baseCheckpointPath = Files.createTempDirectory(getClass.getCanonicalName) + Files.deleteIfExists(baseCheckpointPath); Review Comment: >baseCheckpointPath = Files.createTempDirectory("junit") I didn't get why can't we use `baseCheckpointPath = Files.createTempDirectory(getClass.getCanonicalName)` ? Havig classname in prefix could simplify finding root cause in case of issues IMHO The idea is to use `Files.createTempDirectory` and `deleteIfExists` to be sure that delete is happening at the end and it should not intersect with checkpoint removal -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org