Jiabao-Sun commented on code in PR #23917:
URL: https://github.com/apache/flink/pull/23917#discussion_r1428209269
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/utils/StreamingWithStateTestBase.scala:
##########
@@ -68,8 +69,8 @@ class StreamingWithStateTestBase(state: StateBackendMode)
extends StreamingTestB
super.before()
// set state backend
- // subfolder are managed here because the tests could fail during cleanup
when concurrently executed (see FLINK-33820)
- baseCheckpointPath = TempDirUtils.newFolder(tempFolder)
+ val baseCheckpointPath =
Files.createTempDirectory(getClass.getCanonicalName)
+ Files.deleteIfExists(baseCheckpointPath);
Review Comment:
It's ok to use `Files.createTempDirectory(getClass.getCanonicalName)`.
`TempDirUtils.newFolder(tempFolder)` may still cause problems, it's my fault
of PR 33641.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
