X-czh commented on code in PR #23447: URL: https://github.com/apache/flink/pull/23447#discussion_r1430072448
########## flink-runtime/src/main/java/org/apache/flink/runtime/messages/webmonitor/JobDetails.java: ########## @@ -355,16 +356,21 @@ public String toString() { /** * The CurrentAttempts holds the attempt number of the current representative execution attempt, - * and the attempt numbers of all the running attempts. + * the attempt numbers of all the running attempts, and whether the current execution has + * reached terminal state. */ public static final class CurrentAttempts implements Serializable { private final int representativeAttempt; private final Set<Integer> currentAttempts; - public CurrentAttempts(int representativeAttempt, Set<Integer> currentAttempts) { + private final boolean terminal; Review Comment: Updated, thx~ ########## flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/metrics/MetricStore.java: ########## @@ -57,6 +60,17 @@ public class MetricStore { private static final Logger LOG = LoggerFactory.getLogger(MetricStore.class); + /** + * The set holds the names of the transient metrics which are no longer useful after a subtask + * reaches terminal state and shall be removed to avoid misleading users. + */ Review Comment: Added -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org