X-czh commented on code in PR #23447:
URL: https://github.com/apache/flink/pull/23447#discussion_r1430859019
##########
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/metrics/MetricStore.java:
##########
@@ -570,6 +578,19 @@ void retainSubtasks(Set<Integer> activeSubtasks) {
subtasks.keySet().retainAll(activeSubtasks);
}
+ void removeTransientMetrics(int subtaskIndex) {
+ if (subtasks.containsKey(subtaskIndex)) {
+ // Remove in both places as task metrics are duplicated in
task metric store and
+ // subtask metric store for metrics query on WebInterface.
+ metrics.keySet()
Review Comment:
Addressed, thx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
