flashJd commented on code in PR #728: URL: https://github.com/apache/flink-kubernetes-operator/pull/728#discussion_r1433921836
########## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingExecutor.java: ########## @@ -264,4 +262,21 @@ private static Map<String, String> getVertexParallelismOverrides( }); return overrides; } + + private boolean blockScalingExecution( + Context context, + Map<JobVertexID, ScalingSummary> scalingSummaries, + Configuration conf, + Instant now) { + var scaleEnabled = conf.get(SCALING_ENABLED); + var isExcluded = CalendarUtils.inExcludedPeriods(conf, now); + autoScalerEventHandler.handleScalingEvent( + context, + scalingSummaries, + scaleEnabled, + isExcluded, + conf.get(SCALING_EVENT_INTERVAL)); + + return !scaleEnabled || isExcluded; Review Comment: I've considered just print a log but finally chose adjust autoscaler event handler a bit: 1. Print a log will cause many annoying duplicated logs if exludedPeriods set is relatively wide 2. Now that we have the interval based event trigger method, why not use it @mxm what do you think -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org