gyfora commented on code in PR #728:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/728#discussion_r1434066148
##########
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingExecutor.java:
##########
@@ -264,4 +262,21 @@ private static Map<String, String>
getVertexParallelismOverrides(
});
return overrides;
}
+
+ private boolean blockScalingExecution(
+ Context context,
+ Map<JobVertexID, ScalingSummary> scalingSummaries,
+ Configuration conf,
+ Instant now) {
+ var scaleEnabled = conf.get(SCALING_ENABLED);
+ var isExcluded = CalendarUtils.inExcludedPeriods(conf, now);
+ autoScalerEventHandler.handleScalingEvent(
+ context,
+ scalingSummaries,
+ scaleEnabled,
+ isExcluded,
+ conf.get(SCALING_EVENT_INTERVAL));
+
+ return !scaleEnabled || isExcluded;
Review Comment:
If scaling is blocked or disabled the event that we send out is a
recommendation. Wouldn't it make sense to have uniform events for
recommendation regardless of the cause? The user always knows why it's only a
recommendation, either because the autoscaler is disabled completely or if in a
blocking period
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
