[ 
https://issues.apache.org/jira/browse/FLINK-4997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15666951#comment-15666951
 ] 

ASF GitHub Bot commented on FLINK-4997:
---------------------------------------

Github user aljoscha commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2756#discussion_r88001538
  
    --- Diff: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/WindowedStream.java
 ---
    @@ -800,4 +907,39 @@ public StreamExecutionEnvironment 
getExecutionEnvironment() {
        public TypeInformation<T> getInputType() {
                return input.getType();
        }
    +
    +   private static <T, R, K, W extends Window> ProcessWindowFunction<T, R, 
K, W> wrapWindowFunction(final WindowFunction<T, R, K, W> cleanedFunction) {
    --- End diff --
    
    I see, I'm afraid I didn't communicate that very well.
    
    For `WindowOperator` the user facing `WindowFunction` is already abstracted 
from the actual `WindowOperator` by the `InternalWindowFunction`. I just 
realised that these "AlignedProcessingTimeWindowOperators" don't have that 
abstraction  and directly take a `WindowFunction`, there we would have to 
introduce some level of nesting, either by wrapping a `WindowFunction` in a 
`ProcessWindowFunction` or by also using `InternalWindowFunction` there. Thing 
is, though, that these operators will be removed because their state cannot 
easily made repartitionable (see the work that we did on key-groups and 
repartitionable state).


> Extending Window Function Metadata
> ----------------------------------
>
>                 Key: FLINK-4997
>                 URL: https://issues.apache.org/jira/browse/FLINK-4997
>             Project: Flink
>          Issue Type: New Feature
>          Components: DataStream API, Streaming, Windowing Operators
>            Reporter: Ventura Del Monte
>            Assignee: Ventura Del Monte
>             Fix For: 1.2.0
>
>
> https://cwiki.apache.org/confluence/display/FLINK/FLIP-2+Extending+Window+Function+Metadata



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to