[
https://issues.apache.org/jira/browse/FLINK-4997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15691503#comment-15691503
]
ASF GitHub Bot commented on FLINK-4997:
---------------------------------------
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2756
The changes look very good! 👍
I'll rebase on top of the recent changes that introduced new
`fold()`/`reduce()` and will also reshuffle/squash the commits a bit to make
the history clearer. I hope that's alright.
I'll also change the name of the `process()` method in
`InternalWindowFunction` back to `apply()` so that we have less changes and the
core of the changes is more obvious. You could change that name in a future PR
if you'd like but it's purely internal. I hope this is also alright.
A word on commit titles: we normally use imperative mood, i.e. "Extend
WindowFunction Metadata" instead of "Extending ..." or "Extends ...".
Initially, this might seem strange but you can think of a commit as being the
command to do something. This is a good read on commit messages:
http://chris.beams.io/posts/git-commit/ I'm not writing so much to discourage
you, I just like good commit messages. And I hope you'll keep up the good work
in the code. 😃
Btw, do you also want to do the same changes for `AllWindowedStream`?
> Extending Window Function Metadata
> ----------------------------------
>
> Key: FLINK-4997
> URL: https://issues.apache.org/jira/browse/FLINK-4997
> Project: Flink
> Issue Type: New Feature
> Components: DataStream API, Streaming, Windowing Operators
> Reporter: Ventura Del Monte
> Assignee: Ventura Del Monte
> Fix For: 1.2.0
>
>
> https://cwiki.apache.org/confluence/display/FLINK/FLIP-2+Extending+Window+Function+Metadata
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
