XComp commented on code in PR #22984:
URL: https://github.com/apache/flink/pull/22984#discussion_r1441914909
##########
flink-core/src/main/java/org/apache/flink/api/common/restartstrategy/RestartStrategies.java:
##########
@@ -72,9 +72,23 @@ public static RestartStrategyConfiguration fixedDelayRestart(
* @param restartAttempts Number of restart attempts for the
FixedDelayRestartStrategy
* @param delayInterval Delay in-between restart attempts for the
FixedDelayRestartStrategy
* @return FixedDelayRestartStrategy
+ * @deprecated Use {@link #fixedDelayRestart(int, Duration)}
*/
+ @Deprecated
Review Comment:
I went through the change once more and came to the conclusion that we could
keep this change. You're right when stating that the `RestartStrategies` are
going away, anyway. But it doesn't hurt that we do the deprecation
"independently" of the `RestartStrategies` efforts. That way, we would still
have a consistent code base if (for whatever reason)
[FLIP-381](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=278464992)
gets reverted. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
