XComp commented on PR #22984: URL: https://github.com/apache/flink/pull/22984#issuecomment-1877310802
Thanks for picking this up. We should merge FLINK-32570 soon'ish to not miss it for 1.19. I reiterated over the PR once more with the following changes: * I rebased the branch to most-recent master. * I removed the hotfix PRs which added API-related annotations. That is out-of-scope for this PR. * I improved the naming for some of the methods (`getWindowDuration` becomes `getWindowSize`) * I reorganized/squashed commits into two (it makes sense to look at the two commits individually when doing the next review) PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
