snuyanzin commented on code in PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#discussion_r1444084926
########## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/ParameterizedPredicate.java: ########## @@ -52,8 +69,26 @@ public void setPredicate(String predicate) { } public ParameterizedPredicate combine(String operator, ParameterizedPredicate that) { + int paramIndex = String.format("(%s %s ", this.predicate, operator).length(); + if (!that.indexesOfPredicatePlaceHolders.isEmpty()) { + paramIndex = paramIndex + that.indexesOfPredicatePlaceHolders.get(0); Review Comment: Please have a look at https://github.com/davidradl/flink-connector-jdbc/pull/1 where it is fixed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org