davidradl commented on code in PR #79:
URL:
https://github.com/apache/flink-connector-jdbc/pull/79#discussion_r1448612970
##########
flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcRowDataLookupFunction.java:
##########
@@ -72,6 +72,17 @@ public JdbcRowDataLookupFunction(
DataType[] fieldTypes,
String[] keyNames,
RowType rowType) {
+ this(options, maxRetryTimes, fieldNames, fieldTypes, keyNames,
rowType, null);
+ }
+
+ public JdbcRowDataLookupFunction(
Review Comment:
@libenchao yes we could have done this . I think it is nice for the caller
to not have to include a null value for a parameter it is not concerned with
and overload the constructor. If you feel strongly about this style I can
change it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
