1996fanrui commented on code in PR #24089:
URL: https://github.com/apache/flink/pull/24089#discussion_r1454809594
##########
flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java:
##########
@@ -808,6 +808,31 @@ public class TaskManagerOptions {
code(TaskManagerLoadBalanceMode.NONE.name())))
.build());
+ @Documentation.Section(Documentation.Sections.ALL_TASK_MANAGER)
+ @Documentation.OverrideDefault("System.getProperty(\"log.file\")")
+ public static final ConfigOption<String> TASK_MANAGER_LOG_PATH =
+ ConfigOptions.key("taskmanager.log.path")
+ .stringType()
+ .defaultValue(System.getProperty("log.file"))
+ .withDescription("The path to the log file of the task
manager.");
+
+ @Documentation.Section(Documentation.Sections.ALL_TASK_MANAGER)
+ public static final ConfigOption<Duration> FS_STREAM_OPENING_TIME_OUT =
+ ConfigOptions.key("taskmanager.runtime.fs-timeout")
+ .durationType()
+ .defaultValue(Duration.ZERO)
+ .withDeprecatedKeys("taskmanager.runtime.fs_timeout")
+ .withDescription(
+ "The timeout for filesystem stream opening. A
value of 0 indicates infinite waiting.");
+
+ @Documentation.Section(Documentation.Sections.ALL_TASK_MANAGER)
+ public static final ConfigOption<Integer> LOCAL_NUMBER_TASK_MANAGER =
Review Comment:
nit: how about?
```suggestion
public static final ConfigOption<Integer>
MINI_CLUSTER_NUMBER_TASK_MANAGER =
```
##########
flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java:
##########
@@ -496,7 +503,12 @@ public final class ConfigConstants {
*/
@Deprecated public static final String YARN_TASK_MANAGER_ENV_PREFIX =
"yarn.taskmanager.env.";
- /** Template for the YARN container start invocation. */
+ /**
+ * Template for the YARN container start invocation.
+ *
+ * @deprecated in favor of {@code
YarnConfigOptions#YARN_CONTAINER_START_COMMAND_TEMPLATE}.
Review Comment:
```suggestion
* @deprecated in favor of {@link
YarnConfigOptions#YARN_CONTAINER_START_COMMAND_TEMPLATE}.
```
nit: `@link` is easy to forward in IDEA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
