Sxnan commented on code in PR #24089:
URL: https://github.com/apache/flink/pull/24089#discussion_r1454983956


##########
flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java:
##########
@@ -496,7 +503,12 @@ public final class ConfigConstants {
      */
     @Deprecated public static final String YARN_TASK_MANAGER_ENV_PREFIX = 
"yarn.taskmanager.env.";
 
-    /** Template for the YARN container start invocation. */
+    /**
+     * Template for the YARN container start invocation.
+     *
+     * @deprecated in favor of {@code 
YarnConfigOptions#YARN_CONTAINER_START_COMMAND_TEMPLATE}.

Review Comment:
   I tried before, but it doesn't work. The reason is that flink-core module 
doesn't depend on flink-yarn module, so we cannot link to 
`YarnConfigOptions#YARN_CONTAINER_START_COMMAND_TEMPLATE`, which is defined in 
flink-yarn module. 
   
   YARN_APPLICATION_MASTER_PORT has the same problem, so it uses `@code` as 
weel.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to