X-czh commented on code in PR #24127: URL: https://github.com/apache/flink/pull/24127#discussion_r1456946751
########## flink-core/src/main/java/org/apache/flink/api/common/serialization/SerializerConfig.java: ########## @@ -0,0 +1,413 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.api.common.serialization; + +import org.apache.flink.annotation.PublicEvolving; +import org.apache.flink.api.common.typeinfo.TypeInfoFactory; +import org.apache.flink.configuration.Configuration; +import org.apache.flink.configuration.ConfigurationUtils; +import org.apache.flink.configuration.PipelineOptions; +import org.apache.flink.configuration.ReadableConfig; + +import com.esotericsoftware.kryo.Serializer; + +import java.io.Serializable; +import java.util.LinkedHashMap; +import java.util.LinkedHashSet; +import java.util.List; +import java.util.Objects; +import java.util.stream.Collectors; + +/** + * A config to define the behavior for serializers in Flink job, it manages the registered types and + * serializers. The config is created from job configuration and used by Flink to create serializers + * for data types. + */ +@PublicEvolving +public final class SerializerConfig implements Serializable { + + private static final long serialVersionUID = 1L; + + /** + * In the long run, this field should be somehow merged with the {@link Configuration} from + * StreamExecutionEnvironment. + */ + private final Configuration configuration = new Configuration(); Review Comment: Yes, it's possible to use fields. We just need to introduce a default construct that populates the default values of the fields with the default Configuration object. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
