reswqa commented on code in PR #24127:
URL: https://github.com/apache/flink/pull/24127#discussion_r1457109072


##########
flink-core/src/main/java/org/apache/flink/api/common/serialization/SerializerConfig.java:
##########
@@ -74,8 +68,19 @@ public final class SerializerConfig implements Serializable {
     private LinkedHashMap<Class<?>, Class<TypeInfoFactory<?>>> 
registeredTypeFactories =
             new LinkedHashMap<>();
 
+    private boolean hasGenericTypesEnabled;
+    private boolean forceKryo;
+    private boolean forceAvro;
+
     // 
--------------------------------------------------------------------------------------------
 
+    public SerializerConfig() {

Review Comment:
   Whether we will always call `ExecutionConfig#configure`? If so, the default 
values should not matter.  If not, can we pass these arguments from the 
outside? I kind of dislike creating a configuration object in this class. :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to