davidradl commented on code in PR #79:
URL: 
https://github.com/apache/flink-connector-jdbc/pull/79#discussion_r1459366515


##########
flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcRowDataLookupFunction.java:
##########
@@ -116,6 +124,15 @@ public void open(FunctionContext context) throws Exception 
{
         }
     }
 
+    private FieldNamedPreparedStatement 
setPredicateParams(FieldNamedPreparedStatement statement)
+            throws SQLException {
+        for (int i = 0; i < pushdownParams.length; ++i) {

Review Comment:
   @snuyanzin Thanks I am working on this currently. I can test the method but 
am not sure how to check it worked. My current test shows that the sqltext in 
the statement is not updated with the parameters. I am continuing to look into 
this.    



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to