davidradl commented on code in PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#discussion_r1462396444
########## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcRowDataLookupFunction.java: ########## @@ -63,6 +64,9 @@ public class JdbcRowDataLookupFunction extends LookupFunction { private final JdbcRowConverter jdbcRowConverter; private final JdbcRowConverter lookupKeyRowConverter; + private List<String> resolvedPredicates = new ArrayList<>(); + private Serializable[] pushdownParams = new Serializable[0]; Review Comment: I have change the code since this comment, now so these variables are assigned so cannot be made final. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org