gyfora commented on code in PR #774:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/774#discussion_r1489403136
##########
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/topology/JobTopology.java:
##########
@@ -146,13 +145,18 @@ public static JobTopology fromJsonPlan(
for (JsonNode node : nodes) {
var vertexId = JobVertexID.fromHexString(node.get("id").asText());
var inputList = new HashSet<JobVertexID>();
+ var ioMetrics = metrics.get(vertexId);
+ var finished = finishedVertices.contains(vertexId);
vertexInfo.add(
new VertexInfo(
vertexId,
inputList,
+ null,
node.get("parallelism").asInt(),
maxParallelismMap.get(vertexId),
- finished.contains(vertexId)));
+ maxParallelismMap.get(vertexId),
Review Comment:
I will add an explicit constructor to clean this up instead of relying on
Lombok allArgsConstructor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
