1996fanrui commented on code in PR #774:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/774#discussion_r1494239310
##########
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/metrics/ScalingMetric.java:
##########
@@ -39,12 +39,6 @@ public enum ScalingMetric {
/** Current processing rate. */
CURRENT_PROCESSING_RATE(true),
Review Comment:
Could all callers use the `getRate(ScalingMetric.NUM_RECORDS_IN, vertex,
metricsHistory)` instead of `getAverage(CURRENT_PROCESSING_RATE, vertex,
metricsHistory);`?
If yes, we can remove this metric.
Currently, only one caller use this metric.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
