[
https://issues.apache.org/jira/browse/FLINK-5092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15686946#comment-15686946
]
ASF GitHub Bot commented on FLINK-5092:
---------------------------------------
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2836#discussion_r89129818
--- Diff: pom.xml ---
@@ -955,9 +996,10 @@ under the License.
<reuseForks>${flink.reuseForks}</reuseForks>
<systemPropertyVariables>
<forkNumber>0${surefire.forkNumber}</forkNumber>
+
<mvn.forkNumber>0${surefire.forkNumber}</mvn.forkNumber>
<log4j.configuration>${log4j.configuration}</log4j.configuration>
</systemPropertyVariables>
- <argLine>-Xms256m -Xmx800m
-Dmvn.forkNumber=${surefire.forkNumber} -XX:-UseGCOverheadLimit</argLine>
+ <!-- Do not define argLine here. See
http://www.eclemma.org/jacoco/trunk/doc/prepare-agent-mojo.html -->
--- End diff --
That's bound to cause problems because a lot of code assumes these
arguments here. We shouldn't touch them and instead do as the documentation you
linked suggested:
One of the ways to do this in case of maven-surefire-plugin - is to use
syntax for late property evaluation:
```xml
<argLine>@{argLine} -Xms256m -Xmx800m
-Dmvn.forkNumber=${surefire.forkNumber} -XX:-UseGCOverheadLimit</argLine>
```
> Add integration with Sonarqube and code coverage
> ------------------------------------------------
>
> Key: FLINK-5092
> URL: https://issues.apache.org/jira/browse/FLINK-5092
> Project: Flink
> Issue Type: Improvement
> Components: Tests
> Reporter: Boris Osipov
> Assignee: Boris Osipov
>
> It would be good to have the opportunity to generate test coverage reports
> for Flink and analyze code by SonarQube.
> Parts of tasks:
> - add generate test coverage reports for Flink with new maven profile
> - implement integration with https://analysis.apache.org/
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
