XComp commented on code in PR #24484:
URL: https://github.com/apache/flink/pull/24484#discussion_r1525054790
##########
flink-tests/src/test/java/org/apache/flink/test/misc/JobIDLoggingITCase.java:
##########
@@ -116,18 +116,55 @@ public void testJobIDLogging(@InjectClusterClient
ClusterClient<?> clusterClient
assertJobIDPresent(jobID, 3, checkpointCoordinatorLogging);
assertJobIDPresent(jobID, 6, streamTaskLogging);
+
+ // Expect *at least* the following
+ // - Receive slot request 0d0aa777e9ac73047d35ec6657270462 for job
+ // 3cfdefe3c1ff1ea91661ee3d00c0f21a from resource manager with leader
id
+ // b7c6e00948bd0a00a1d15c6d87454ce0.,
+ // - Establish JobManager connection for job
3cfdefe3c1ff1ea91661ee3d00c0f21a.,
+ // - Offer reserved slots to the leader of job
3cfdefe3c1ff1ea91661ee3d00c0f21a.,
+ // - Received task Source: Sequence Source -> Sink: Unnamed (1/1)#0
+ //
(1e4894ed9ef9533cac2effb6f7f3e6b3_cbc357ccb763df2852fee8c4fc7d55f2_0_0), deploy
into slot
+ // with allocation id 0d0aa777e9ac73047d35ec6657270462.,
+ // - Operator event for
+ //
1e4894ed9ef9533cac2effb6f7f3e6b3_cbc357ccb763df2852fee8c4fc7d55f2_0_0 -
+ // cbc357ccb763df2852fee8c4fc7d55f2,
+ // - Trigger checkpoint 1@1710170116122 for
+ //
1e4894ed9ef9533cac2effb6f7f3e6b3_cbc357ccb763df2852fee8c4fc7d55f2_0_0.,
assertJobIDPresent(
jobID,
- 9,
Review Comment:
can't we make this number of expected log events another set of patterns
that would be passed in? That would allow for a more detailed assertion in
`assertJobIDPresent` and would avoid having this long comment here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
