rkhachatryan commented on code in PR #24484:
URL: https://github.com/apache/flink/pull/24484#discussion_r1526329297
##########
flink-test-utils-parent/flink-test-utils-junit/src/main/java/org/apache/flink/testutils/logging/LoggerAuditingExtension.java:
##########
@@ -81,7 +81,9 @@ public void beforeEach(ExtensionContext context) throws
Exception {
new AbstractAppender("test-appender", null, null, false,
Property.EMPTY_ARRAY) {
@Override
public void append(LogEvent event) {
- loggingEvents.add(event.toImmutable());
+ if (event.toImmutable() != null) {
+ loggingEvents.add(event.toImmutable());
+ }
Review Comment:
I've seen NPE logged, but don't see it anymore - will remove the check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
