gaborgsomogyi commented on code in PR #789:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/789#discussion_r1562302534
##########
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingExecutor.java:
##########
@@ -199,6 +214,85 @@ protected static boolean
allVerticesWithinUtilizationTarget(
return true;
}
+ protected static boolean resourceQuotaReached(
Review Comment:
I've made a deep-dive here and the conclusion is to have a single function
where both called. They seem to do similar things but the fact is that the
commonality is more or less the following:
```
var tmCpu = ctx.getTaskManagerCpu().orElse(0.);
var tmMemory = MemoryTuning.getTotalMemory(tunedConfig, ctx);
var numSlotsPerTm =
tunedConfig.get(TaskManagerOptions.NUM_TASK_SLOTS);
```
All in all I've wrapped them together but in a separate function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
