gaborgsomogyi commented on code in PR #789:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/789#discussion_r1562336481
##########
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingExecutor.java:
##########
@@ -129,8 +133,10 @@ public boolean scaleResource(
scalingSummaries,
autoScalerEventHandler);
- if (scalingWouldExceedClusterResources(
- configOverrides.newConfigWithOverrides(conf),
+ var memoryTuningEnabled =
conf.get(AutoScalerOptions.MEMORY_TUNING_ENABLED);
+ if (scalingWouldExceedMaxResources(
+ memoryTuningEnabled ?
configOverrides.newConfigWithOverrides(conf) : conf,
Review Comment:
@mxm this is basically a bugfix. The original code assumed that memory
tuning is always enabled which is not true.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
