Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2509#discussion_r89362689
--- Diff:
flink-streaming-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/SimpleConsumerThread.java
---
@@ -408,23 +412,32 @@ else if (partitionsRemoved) {
}
}
- private void getMissingOffsetsFromKafka(
+ private void replaceEarliestOrLatestOffsetsWithActualValuesFromKafka(
List<KafkaTopicPartitionState<TopicAndPartition>>
partitions) throws IOException
{
// collect which partitions we should fetch offsets for
- List<KafkaTopicPartitionState<TopicAndPartition>>
partitionsToGetOffsetsFor = new ArrayList<>();
+ List<KafkaTopicPartitionState<TopicAndPartition>>
partitionsWithEarliestOffsetSetting = new ArrayList<>();
--- End diff --
Good point, didn't think of that. I'll call `getLastOffsetFromKafka` if
getOffset() returns `OffsetRequest.EarliestTime()` or
`OffsetRequest.LatestTime()`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
