Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2509#discussion_r89755818
--- Diff:
flink-streaming-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/SimpleConsumerThread.java
---
@@ -460,15 +433,13 @@ public void cancel() {
//
------------------------------------------------------------------------
/**
- * Request latest offsets for a set of partitions, via a Kafka consumer.
- *
- * <p>This method retries three times if the response has an error.
+ * Request offsets before a specific time for a set of partitions, via
a Kafka consumer.
*
* @param consumer The consumer connected to lead broker
* @param partitions The list of partitions we need offsets for
* @param whichTime The type of time we are requesting. -1 and -2 are
special constants (See OffsetRequest)
*/
- private static void getLastOffsetFromKafka(
+ private static void requestAndSetSpecificTimeOffsetsFromKafka(
--- End diff --
Refactored the utility Kafka request methods in this class to avoid
creating redundant lists.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
