nicusX commented on code in PR #1:
URL: 
https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1597478707


##########
prometheus-connector/src/main/java/org/apache/flink/connector/prometheus/sink/prometheus/Remote.java:
##########
@@ -0,0 +1,6661 @@
+/*

Review Comment:
   I think we discussed this.
   Generating the Java classes from proto cannot be done with a pure Java 
solution included in the project. 
   It requires ProtoBuf binaries. (e.g. see 
https://github.com/javiroman/jremotewrite/blob/e1b5d9865d42254b32f2da6ddfd6956569577601/pom.xml#L210)
   
    I am adding the *.proto file for reference and a section to the README to 
explain



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to