yunfengzhou-hub commented on code in PR #24748:
URL: https://github.com/apache/flink/pull/24748#discussion_r1597838569


##########
flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/AsyncExecutionController.java:
##########
@@ -102,6 +104,12 @@ public class AsyncExecutionController<K> implements 
StateRequestHandler {
     /** Max parallelism of the job. */
     private final int maxParallelism;
 
+    /** The reference of epoch manager. */
+    final EpochManager epochManager;
+
+    /** The parallel mode of epoch execution. */
+    ParallelMode epochParallelMode = ParallelMode.SERIAL_BETWEEN_EPOCH;

Review Comment:
   It seems that this parameter can be removed.



##########
flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/AsyncExecutionController.java:
##########
@@ -311,6 +324,22 @@ public void drainInflightRecords(int targetNum) {
         }
     }
 
+    public void processNonRecord(Runnable action) {
+        epochManager.onNonRecord(action, epochParallelMode);
+    }
+
+    /**
+     * Configure the parallel mode of epoch execution. We should keep this 
method internal for now,
+     * until we could see the concrete need for {@link 
ParallelMode#PARALLEL_BETWEEN_EPOCH} from
+     * average users.
+     *
+     * @param parallelMode the parallel mode to set.
+     */
+    @Internal
+    void configureEpochParallelMode(ParallelMode parallelMode) {

Review Comment:
   Same as above.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to