fredia commented on code in PR #24748: URL: https://github.com/apache/flink/pull/24748#discussion_r1601082456
########## flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/asyncprocessing/AbstractAsyncStateStreamOperatorV2.java: ########## @@ -188,6 +190,35 @@ public <K, N> InternalTimerService<N> getInternalTimerService( (AsyncExecutionController<K>) asyncExecutionController); } + @Override + public void processWatermark(Watermark mark) throws Exception { + if (!isAsyncStateProcessingEnabled()) { + super.processWatermark(mark); + return; + } + asyncExecutionController.processNonRecord(() -> super.processWatermark(mark)); Review Comment: `AbstractStreamOperatorV2` does not implement `processWatermark1 `, `processWatermark2` and `processWatermark(Watermark, int)`, if those methods will be added in the future, I would override them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org