morazow commented on code in PR #24426: URL: https://github.com/apache/flink/pull/24426#discussion_r1613226372
########## .github/workflows/nightly.yml: ########## @@ -94,3 +94,51 @@ jobs: s3_bucket: ${{ secrets.IT_CASE_S3_BUCKET }} s3_access_key: ${{ secrets.IT_CASE_S3_ACCESS_KEY }} s3_secret_key: ${{ secrets.IT_CASE_S3_SECRET_KEY }} + + build_python_wheels: + name: "Build Python Wheels on ${{ matrix.os }}" Review Comment: Hey @XComp, I think this is fine. The Azure Pipelines (https://github.com/apache/flink/blob/master/tools/azure-pipelines/build-python-wheels.yml) also run like that, builds each wheel in a separate job. From [GitHub migration doc](https://docs.github.com/en/actions/migrating-to-github-actions/manually-migrating-to-github-actions/migrating-from-azure-pipelines-to-github-actions#migrating-jobs-and-steps): ``` - Jobs contain a series of steps that run sequentially. - Jobs run on separate virtual machines or in separate containers. - Jobs run in parallel by default, but can be configured to run sequentially. ``` So should be fine to build each wheel separately without the Flink build similar to the Azure Pipelines. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org