morazow commented on code in PR #24426:
URL: https://github.com/apache/flink/pull/24426#discussion_r1613261308
##########
.github/workflows/nightly.yml:
##########
@@ -94,3 +94,51 @@ jobs:
s3_bucket: ${{ secrets.IT_CASE_S3_BUCKET }}
s3_access_key: ${{ secrets.IT_CASE_S3_ACCESS_KEY }}
s3_secret_key: ${{ secrets.IT_CASE_S3_SECRET_KEY }}
+
+ build_python_wheels:
+ name: "Build Python Wheels on ${{ matrix.os }}"
+ runs-on: ${{ matrix.os }}
+ strategy:
+ fail-fast: false
+ matrix:
+ include:
+ - os: ubuntu-latest
+ os_name: linux
+ python-version: 3.9
+ - os: macos-latest
+ os_name: macos
+ python-version: 3.9
Review Comment:
Yes on macos the only pyproject.toml is used by cibuildwheel. Tools seems to
be well documented, maybe we could also use it for linux builds.
It uses the `cp38-*`, etc for Python versions,
https://cibuildwheel.pypa.io/en/stable/options/#build-skip. For Linux we are
running bash scripts for building wheel, but we could let the cibuildwheel
action do for both platforms.
We can ask @HuangXingBo for final review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
