[ 
https://issues.apache.org/jira/browse/FLINK-5026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15701725#comment-15701725
 ] 

ASF GitHub Bot commented on FLINK-5026:
---------------------------------------

Github user kl0u commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2788#discussion_r89761615
  
    --- Diff: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/co/CoProcessFunction.java
 ---
    @@ -119,7 +115,7 @@
        /**
         * Information available in an invocation of {@link #onTimer(long, 
OnTimerContext, Collector)}.
         */
    -   interface OnTimerContext extends TimelyFlatMapFunction.Context {
    +   interface OnTimerContext extends ProcessFunction.Context {
                /**
    --- End diff --
    
    It should extend the local `Context`, not the `ProcessFunction` one.


> Rename TimelyFlatMap to Process
> -------------------------------
>
>                 Key: FLINK-5026
>                 URL: https://issues.apache.org/jira/browse/FLINK-5026
>             Project: Flink
>          Issue Type: Improvement
>          Components: Streaming
>            Reporter: Aljoscha Krettek
>            Assignee: Aljoscha Krettek
>             Fix For: 1.2.0
>
>
> The method on {{KeyedDataStream}} would be called {{process()}} and the 
> function itself would be called {{ProcessFunction}}.
> The reason for this is that {{TimelyFlatMapFunction}} is a bit of a mouthful 
> and with the additions to the timer API and state the {{ProcessFunction}} 
> could become the basic, low-level, user-facing API for cases where users 
> nowadays implement their own operator.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to