[
https://issues.apache.org/jira/browse/FLINK-4825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15701739#comment-15701739
]
ASF GitHub Bot commented on FLINK-4825:
---------------------------------------
GitHub user twalthr opened a pull request:
https://github.com/apache/flink/pull/2884
[FLINK-4825] [table] Implement a RexExecutor that uses Flink's code
generation
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [x] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [x] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [x] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
This PR solves the issues for constant expression reduction and enables the
rules for it.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/twalthr/flink FLINK-4825
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2884.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2884
----
commit 25af5ab616e21e06b01eb773c3b06168b46d9dd5
Author: twalthr <[email protected]>
Date: 2016-11-28T11:18:36Z
[FLINK-4825] [table] Implement a RexExecutor that uses Flink's code
generation
----
> Implement a RexExecutor that uses Flink's code generation
> ---------------------------------------------------------
>
> Key: FLINK-4825
> URL: https://issues.apache.org/jira/browse/FLINK-4825
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
> Reporter: Timo Walther
> Assignee: Timo Walther
>
> The added {{ReduceExpressionRule}} leads to inconsistent behavior. Because
> some parts of an expression are evalutated using Flink's code generation and
> some parts use Calcite's code generation.
> A very easy example: boolean expressions casted to string are represented as
> "TRUE/FALSE" using Calcite and "true/false" using Flink.
> I propose to implement the RexExecutor interface and forward the calls to
> Flink's code generation. Additional improvements in order to be more standard
> compliant could be solved in new Jira issues.
> I will disable the rule and the corresponding tests till this issue is fixed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
