[
https://issues.apache.org/jira/browse/FLINK-4825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15703228#comment-15703228
]
ASF GitHub Bot commented on FLINK-4825:
---------------------------------------
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/2884
+1 to merge
> Implement a RexExecutor that uses Flink's code generation
> ---------------------------------------------------------
>
> Key: FLINK-4825
> URL: https://issues.apache.org/jira/browse/FLINK-4825
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
> Reporter: Timo Walther
> Assignee: Timo Walther
>
> The added {{ReduceExpressionRule}} leads to inconsistent behavior. Because
> some parts of an expression are evalutated using Flink's code generation and
> some parts use Calcite's code generation.
> A very easy example: boolean expressions casted to string are represented as
> "TRUE/FALSE" using Calcite and "true/false" using Flink.
> I propose to implement the RexExecutor interface and forward the calls to
> Flink's code generation. Additional improvements in order to be more standard
> compliant could be solved in new Jira issues.
> I will disable the rule and the corresponding tests till this issue is fixed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
