loserwang1024 opened a new pull request, #3388:
URL: https://github.com/apache/flink-cdc/pull/3388

   Current, inJdbcConnectionPools is static instance, so the datasource pools 
in it won't be recycle when reader close. It will cause memory leak.
   
   ```java
   public class JdbcConnectionPools implements 
ConnectionPools<HikariDataSource, JdbcSourceConfig> {
   
   private static final Logger LOG = 
LoggerFactory.getLogger(JdbcConnectionPools.class);
   
   private static JdbcConnectionPools instance;
   private final Map<ConnectionPoolId, HikariDataSource> pools = new 
HashMap<>();
   private static final Map<String, JdbcConnectionPoolFactory> POOL_FACTORY_MAP 
= new HashMap<>();
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to