Jiabao-Sun commented on code in PR #3388:
URL: https://github.com/apache/flink-cdc/pull/3388#discussion_r1627350103
##########
flink-cdc-connect/flink-cdc-source-connectors/flink-cdc-base/src/main/java/org/apache/flink/cdc/connectors/base/source/reader/IncrementalSourceReader.java:
##########
@@ -541,4 +542,11 @@ private void logCurrentStreamOffsets(List<SourceSplitBase>
splits, long checkpoi
LOG.info("Stream split offset on checkpoint {}: {}", checkpointId,
offset);
}
}
+
+ @Override
+ public void close() throws Exception {
+ // clear jdbc connection pools
+ JdbcConnectionPools.close();
Review Comment:
Some abstraction is needed here because the sources we support are not
limited to just the jdbc datasource. Perhaps we should delegate the
implementation of closing the connection pool to DataSourceDialect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
