gaborgsomogyi commented on code in PR #25231:
URL: https://github.com/apache/flink/pull/25231#discussion_r1726738564
##########
flink-filesystems/flink-s3-fs-base/src/main/java/org/apache/flink/fs/s3/common/writer/S3RecoverableFsDataOutputStream.java:
##########
@@ -129,10 +129,9 @@ public void sync() throws IOException {
lock();
try {
fileStream.flush();
- openNewPartIfNecessary(userDefinedMinPartSize);
+ uploadCurrentAndOpenNewPart(fileStream.getPos());
Review Comment:
We're testing the code in our internal system with file sink compaction
use-case. @hlteoh37 can you plz help by executing the mentioned test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
