gaborgsomogyi commented on code in PR #25231:
URL: https://github.com/apache/flink/pull/25231#discussion_r1732792672


##########
flink-filesystems/flink-s3-fs-base/src/main/java/org/apache/flink/fs/s3/common/writer/S3RecoverableFsDataOutputStream.java:
##########
@@ -129,10 +129,9 @@ public void sync() throws IOException {
         lock();
         try {
             fileStream.flush();
-            openNewPartIfNecessary(userDefinedMinPartSize);
+            uploadCurrentAndOpenNewPart(fileStream.getPos());

Review Comment:
   Does anybody knows where are these tests? It would be good to proceed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to