davidradl commented on code in PR #969:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/969#discussion_r2077806156
##########
flink-kubernetes-operator-api/src/main/java/org/apache/flink/kubernetes/operator/api/utils/SpecUtils.java:
##########
@@ -99,6 +99,28 @@ public static String writeSpecWithMeta(
}
}
+ public static String serializeObject(Object object, String wrapperKey) {
Review Comment:
I see that `serializeObject` seems to be only called for specs and I see the
previous method is called `writeSpecWithMeta`. I suggest being consistent with
the method names, maybe `writeSpecAsJSON`.
The key seems to always be called with "spec", could we hard code it here -
if this is the case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
