Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/2976#discussion_r94104766
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateReduceCombineFunction.scala
---
@@ -41,12 +41,14 @@ class AggregateReduceCombineFunction(
private val aggregates: Array[Aggregate[_ <: Any]],
private val groupKeysMapping: Array[(Int, Int)],
private val aggregateMapping: Array[(Int, Int)],
+ private val additionalMapping: Array[(Int, Int)],
--- End diff --
Can we have a more explicit name about "what is the additional mapping?".
And we should update the class document.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
