davidradl commented on code in PR #26594:
URL: https://github.com/apache/flink/pull/26594#discussion_r2110170096
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/data/binary/BinaryArrayData.java:
##########
@@ -372,7 +372,11 @@ public void setDecimal(int pos, DecimalData value, int
precision) {
if (DecimalData.isCompact(precision)) {
// compact format
- setLong(pos, value.toUnscaledLong());
+ if (value == null) {
Review Comment:
this if code is duplicated more than once by this fix, can we refactor to a
method remove the duplication.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
