davidradl commented on code in PR #26594:
URL: https://github.com/apache/flink/pull/26594#discussion_r2113953620
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/data/binary/BinaryArrayData.java:
##########
@@ -372,7 +372,11 @@ public void setDecimal(int pos, DecimalData value, int
precision) {
if (DecimalData.isCompact(precision)) {
// compact format
- setLong(pos, value.toUnscaledLong());
+ if (value == null) {
Review Comment:
My concern is that we have added a lot of duplicate code with the `if elses`
added in this fix. It seems prudent to have a common method so the logic does
not diverge in the different cases.
@snuyanzin WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
