davidradl commented on code in PR #26653: URL: https://github.com/apache/flink/pull/26653#discussion_r2135752975
########## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/inference/LookupCallContext.java: ########## @@ -35,14 +34,15 @@ import java.util.Optional; import static org.apache.flink.table.functions.UserDefinedFunctionHelper.generateInlineFunctionName; +import static org.apache.flink.table.planner.plan.utils.FunctionCallUtils.FieldRef; import static org.apache.flink.table.types.logical.utils.LogicalTypeChecks.getFieldTypes; import static org.apache.flink.table.types.utils.TypeConversions.fromLogicalToDataType; /** The {@link CallContext} of a {@link LookupTableSource} runtime function. */ @Internal public class LookupCallContext extends AbstractSqlCallContext { - private final List<LookupKey> lookupKeys; + private final List<Variable> lookupKeys; Review Comment: nit: I guess this variable should not be call lookupKeys anymore in line with the type change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org