fsk119 commented on code in PR #26653:
URL: https://github.com/apache/flink/pull/26653#discussion_r2136779235
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/inference/LookupCallContext.java:
##########
@@ -35,14 +34,15 @@
import java.util.Optional;
import static
org.apache.flink.table.functions.UserDefinedFunctionHelper.generateInlineFunctionName;
+import static
org.apache.flink.table.planner.plan.utils.FunctionCallUtils.FieldRef;
import static
org.apache.flink.table.types.logical.utils.LogicalTypeChecks.getFieldTypes;
import static
org.apache.flink.table.types.utils.TypeConversions.fromLogicalToDataType;
/** The {@link CallContext} of a {@link LookupTableSource} runtime function. */
@Internal
public class LookupCallContext extends AbstractSqlCallContext {
- private final List<LookupKey> lookupKeys;
+ private final List<Variable> lookupKeys;
Review Comment:
My idea is from calcite, it has RexLiteral, RexInputRef, RexVariable.
Actually, we remove the LookupKeys and use Variable instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
