wenjin272 commented on code in PR #6: URL: https://github.com/apache/flink-agents/pull/6#discussion_r2139738353
########## python/flink_agents/plan/function.py: ########## @@ -0,0 +1,102 @@ +################################################################################ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +################################################################################# + +import importlib +import inspect +from typing import Any, Callable, Dict, Tuple + +from pydantic import BaseModel + + +class Function(BaseModel): Review Comment: make sense ########## python/flink_agents/plan/tests/test_workflow_plan.py: ########## @@ -0,0 +1,47 @@ +################################################################################ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +################################################################################# + +from flink_agents.api.event import InputEvent, OutputEvent +from flink_agents.plan.action import Action +from flink_agents.plan.function import Function +from flink_agents.plan.workflow_plan import WorkflowPlan + + +def increment(event: InputEvent) -> OutputEvent: # noqa: D103 + value = event.input + value += 1 + return OutputEvent(isLegal=True, result=value) Review Comment: Fully agree. I add some comments on this function , or I can delete this test case and add it back after we import RunnerContext. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
