xintongsong commented on code in PR #6:
URL: https://github.com/apache/flink-agents/pull/6#discussion_r2142226931
##########
python/flink_agents/api/tests/test_event.py:
##########
@@ -18,16 +18,25 @@
from typing import Type
import pytest
+from pydantic import ValidationError
+from pydantic_core import PydanticSerializationError
-from flink_agents.api.event import Event
+from flink_agents.api.event import Event, InputEvent, OutputEvent
-def test_event_serializable() -> None: #noqa D103
- event = Event(a="1")
- event.model_dump_json()
+def test_event_serializable_valid() -> None: #noqa D103
Review Comment:
test_event_init_serializable
test_event_init_non_serializable
test_event_setattr_serializable
test_event_setattr_non_serializable
##########
python/flink_agents/plan/function.py:
##########
@@ -76,9 +76,16 @@ def from_callable(func: Callable) -> Function:
__func=func,
)
- def check_signature(self, checker: Callable) -> None:
- """Apply external check logic to function signature."""
- checker(self.__get_func())
+ def check_signature(self, *args: Tuple[Any, ...]) -> None:
Review Comment:
I think we need more comprehensive tests for this function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
